Update WC plugin matching to use the file name in plugin path: use cases that match plugin by name - part 3 #15947

jaclync · 2025-07-24T18:21:49Z

Just one review is required.

Description

This is part 3 of the effort to replace plugin matching by name with plugin file name matching. It uses the centralized Plugin enum hiding the file name matching implementation.

Key Changes

Enhanced Plugin enum: Added new plugin cases (blaze, PayPal, etc.) and two new initializers with unit tests
Updated plugin matching logic: Refactored most remaining use cases to use the Plugin enum instead of string plugin name matching

This change improves the reliability of plugin detection for merchants and provides a more robust foundation for future plugin-related features.

Testing steps

Please feel free to pick up one or more of the test cases below.

Testing information

Testing one of the states for each case is fine.

Analytics Hub - Plugin-Dependent Cards

@jaclync tests this

WooCommerce Product Bundles Plugin

Test Active State:
- Install and activate WooCommerce Product Bundles plugin
- Navigate to dashboard > View all store analytics
- Expected: Product Bundles analytics card should be visible and functional
Test Inactive State:
- Deactivate (but keep installed) WooCommerce Product Bundles plugin
- Navigate to dashboard > View all store analytics
- Expected: Product Bundles analytics card should be hidden/disabled

WooCommerce Gift Cards Plugin

Test Active State:
- Install and activate WooCommerce Gift Cards plugin
- Navigate to dashboard > View all store analytics
- Expected: Gift Cards analytics card should be visible and functional
Test Inactive State:
- Deactivate WooCommerce Gift Cards plugin
- Navigate to dashboard > View all store analytics
- Expected: Gift Cards analytics card should be hidden/disabled

Google Listings and Ads Plugin

Test Active State:
- Install and activate Google Listings and Ads plugin
- Navigate to dashboard > View all store analytics
- Expected: Google Campaigns analytics card should be visible
Test Inactive State:
- Deactivate Google Listings and Ads plugin
- Navigate to dashboard > View all store analytics
- Expected: Google Campaigns analytics card should be hidden

Product Filter

@jaclync tests this

WooCommerce Subscriptions Plugin

Test Active State:
- Install and activate WooCommerce Subscriptions plugin
- Navigate to Products → Filter > Product Type
- Expected: "Subscription" product types should be available
Test Inactive State:
- Deactivate WooCommerce Subscriptions plugin
- Navigate to Products → Filter > Product Type
- Expected: "Subscription" product type should show as "Explore" with promote URL

WooCommerce Product Bundles Plugin

Test Active State:
- Install and activate WooCommerce Product Bundles plugin
- Navigate to Products → Filter > Product Type
- Expected: "Bundle" product type should be available
Test Inactive State:
- Deactivate WooCommerce Product Bundles plugin
- Navigate to Products → Filter > Product Type
- Expected: "Bundle" product type should show as "Explore"
  with promote URL

WooCommerce Composite Products Plugin

Test Active State:
- Install and activate WooCommerce Composite Products plugin
- Navigate to Products → Filter > Product Type
- Expected: "Composite" product type should be available
Test Inactive State:
- Deactivate WooCommerce Composite Products plugin
- Navigate to Products → Filter > Product Type
- Expected: "Composite" product type should show as "Explore" with promote URL

Product Password Feature

@jaclync tests this

WooCommerce Version Requirements

Test Version 8.1.0+:
- Ensure WooCommerce plugin is active with version 8.1.0 or higher
- Edit a product → Product Settings → Visibility
- Expected: Password protection options should be available via mobile app
Test Version Below 8.1.0:
- Downgrade WooCommerce to version below 8.1.0 (if possible in test environment)
- Edit a product → Product Settings → Visibility
- Expected: Should fall back to legacy password handling

Blaze Plugin Integration

@jaclync tests this

Note: I had to comment out some checks in BlazeEligibilityChecker.checkSiteEligibility to reach the Blaze plugin check.

Site with Blaze plugin & not Jetpack plugin (which already includes Blaze feature):
- Expected: the dashboard should have a Blaze card (edit the cards to see the option)
Site without Blaze & Jetpack plugin:
- Expected: the dashboard should not have a Blaze card

Jetpack Plugin Integration

@jaclync tests this

Jetpack plugin state

Site with Jetpack plugin:
- Expected: no Jetpack installation banner
Site without Jetpack plugin:
- Expected: Jetpack installation banner in the dashboard

Screenshots

product filter	analytics hub

I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

…ch system plugins using `ResultsController`.

…that matches by plugin file name.

…matches by plugin file name.

…iewModel` changes.

…ng with Plugin enum.

…the app layer.

… Plugin enum. Add active state filter. Fix a build warning in its test file.

…at all use cases are replaced with Plugin enum.

…m with active state filtering.

wpmobilebot · 2025-07-24T18:30:59Z

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	`pr15947-aaf186f`
	Version	`22.8`
	Bundle ID	`com.automattic.alpha.woocommerce`
	Commit	`aaf186f`
	Installation URL	6nabc7h2bnjlg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

…ameWithoutExtension` as private.

staskus

Code changes look good 👍

I picked a few random plugins to confirm the functionality:
✅ Bundles
✅ Gift cards
✅ Blaze
✅ Subscriptions

staskus · 2025-07-25T07:04:38Z

...ests/ViewRelated/Products/Edit Product/Settings/ProductPasswordEligibilityUseCaseTests.swift

 }
+
+private extension ProductPasswordEligibilityUseCaseTests {
+    func insertWooCommercePlugin(version: String, active: Bool) {


jaclync added 12 commits July 24, 2025 11:35

Create Plugin initializer for SystemPlugin for use cases that fet…

e697a0f

…ch system plugins using `ResultsController`.

FilterProductListViewModel: replace plugin name matching with Plugin …

95c2da8

…that matches by plugin file name.

AnalyticsHubViewModel: replace plugin name matching with Plugin that …

5b01437

…matches by plugin file name.

Update test cases for AnalyticsHubViewModel and `FilterProductListV…

6a46cf3

…iewModel` changes.

JetpackSetupCoordinator: replace plugin name matching with Plugin enum.

6474264

WooSubscriptionProductsEligibilityChecker: replace plugin name matchi…

ab93e5e

…ng with Plugin enum.

Remove Yosemite.SystemPlugin.fileNameWithoutExtension extension in …

22df466

…the app layer.

Replace fileNameWithoutExtension use cases with Plugin enum.

4770d89

DefaultGoogleAdsEligibilityChecker: replace plugin path matching with…

529c208

… Plugin enum. Add active state filter. Fix a build warning in its test file.

Remove unused SitePlugin.SupportedPlugin plugin name constants now th…

7180ff0

…at all use cases are replaced with Plugin enum.

BlazeEligibilityChecker: replace plugin path matching with Plugin enu…

da8961e

…m with active state filtering.

Add test cases for Plugin initializers.

8505971

jaclync added the type: technical debt Represents or solves tech debt of the project. label Jul 24, 2025

jaclync added this to the 22.9 milestone Jul 24, 2025

jaclync added 2 commits July 24, 2025 14:34

Nits: remove unused plugin name constant and mark `SystemPlugin.fileN…

7b72ab7

…ameWithoutExtension` as private.

Nits: update comments.

aaf186f

jaclync modified the milestones: 22.9, 23.0 Jul 24, 2025

jaclync requested review from iamgabrielma and staskus July 24, 2025 19:40

staskus approved these changes Jul 25, 2025

View reviewed changes

jaclync merged commit 8f77c38 into trunk Jul 25, 2025
26 of 29 checks passed

jaclync deleted the backlog/WOOMOB-913-part-3-replace-plugin-matching-by-name branch July 25, 2025 17:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update WC plugin matching to use the file name in plugin path: use cases that match plugin by name - part 3 #15947

Update WC plugin matching to use the file name in plugin path: use cases that match plugin by name - part 3 #15947

Uh oh!

jaclync commented Jul 24, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 24, 2025 •

edited

Loading

Uh oh!

staskus left a comment

Uh oh!

staskus Jul 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Update WC plugin matching to use the file name in plugin path: use cases that match plugin by name - part 3 #15947

Update WC plugin matching to use the file name in plugin path: use cases that match plugin by name - part 3 #15947

Uh oh!

Conversation

jaclync commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Key Changes

Testing steps

Testing information

Screenshots

Uh oh!

wpmobilebot commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

staskus left a comment

Choose a reason for hiding this comment

Uh oh!

staskus Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jaclync commented Jul 24, 2025 •

edited

Loading

wpmobilebot commented Jul 24, 2025 •

edited

Loading